Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mosquitto_string_option returns 3 for MOSQ_OPT_TLS_KEYFORM with proper input #1360

Closed
MikeDombo opened this issue Jul 30, 2019 · 2 comments

Comments

@MikeDombo
Copy link

commented Jul 30, 2019

mosquitto_string_option returns 3 which is MOSQ_ERR_INVAL when setting MOSQ_OPT_TLS_KEYFORM because the success cases don't return success, they just fallthrough and return the default.

ralight added a commit that referenced this issue Jul 30, 2019

Fix mosquitto_string_option(, MOSQ_OPT_TLS_KEYFORM, ) return value
`mosquitto_string_option(mosq, MOSQ_OPT_TLS_KEYFORM, ...)` was incorrectly
returning `MOSQ_ERR_INVAL` with valid input. This has been fixed.

Closes #1360. Thanks to Michael Dombrowski.
@ralight

This comment has been minimized.

Copy link
Contributor

commented Jul 30, 2019

Thanks, that should be fixed now.

@ralight ralight added this to the 1.6.4 milestone Jul 30, 2019

@MikeDombo

This comment has been minimized.

Copy link
Author

commented Jul 30, 2019

Thanks for the quick fix!

@MikeDombo MikeDombo closed this Jul 30, 2019

vankxr added a commit to vankxr/mosquitto that referenced this issue Aug 9, 2019

Fix mosquitto_string_option(, MOSQ_OPT_TLS_KEYFORM, ) return value
`mosquitto_string_option(mosq, MOSQ_OPT_TLS_KEYFORM, ...)` was incorrectly
returning `MOSQ_ERR_INVAL` with valid input. This has been fixed.

Closes eclipse#1360. Thanks to Michael Dombrowski.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.