Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mosquitto_passwd returns 0 instead of 1 if the specified user was not found. #1414

Closed
kdgde opened this issue Sep 17, 2019 · 1 comment
Closed

mosquitto_passwd returns 0 instead of 1 if the specified user was not found. #1414

kdgde opened this issue Sep 17, 2019 · 1 comment
Labels
Type: Bug
Milestone
1.6.6

Comments

@kdgde
Copy link

kdgde commented Sep 17, 2019

224 if(!found){
225 fprintf(stderr, "Warning: User %s not found in password file.\n", username);
226 }

Better for scripts (get return code):
224 if(!found){
225 fprintf(stderr, "Warning: User %s not found in password file.\n", username);
225 return 1;
227 }
ralight added a commit that referenced this issue Sep 17, 2019
@ralight
mosquitto_passwd returns 1 on an error condition
2fd7f52 
When attempting to update a user that does not exist.

Closes #1414. Thanks to kdgde.
@ralight
Copy link
Contributor

ralight commented Sep 17, 2019

Agreed, that should be an error. Thanks for the suggestion, it will be in 1.6.6.

@ralight ralight closed this as completed Sep 17, 2019
@ralight ralight added this to the 1.6.6 milestone Sep 17, 2019
ralight added a commit that referenced this issue Sep 18, 2019
@ralight
mosquitto_passwd returns 1 on an error condition
814875b 
When attempting to update a user that does not exist.

Closes #1414. Thanks to kdgde.
@lock lock bot locked as resolved and limited conversation to collaborators Dec 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Type: Bug
Projects
None yet
Milestone
1.6.6
Development

No branches or pull requests
2 participants
@ralight @kdgde