#if defined(LIBRESSL_VERSION_NUMBER) #2198
Labels
Component: mosquitto-clients
Status: Completed
Nothing further to be done with this issue, it can be closed by the requestor or committer.
Type: Bug
Milestone
lib/options.ccurrently has two#if defined(LIBRESSL_VERSION_NUMBER)code paths.mosquitto/lib/options.c
Lines 397 to 400 in d5ecd9f
and
mosquitto/lib/options.c
Lines 505 to 506 in d5ecd9f
This is to avoid using
SSL_CTX_up_ref()that presumably was not available at the time of writing the code.This function has been available since LibreSSL 2.7.0 and is thus available in all supported versions (currently 3.2.x and 3.3.x).
It would be nice if these
&& !defined(LIBRESSL_VERSION_NUMBER)could be removed, as in LibreSSL 3.4.x theSSL_CTXwill become opaque, so the build will break.Concerning the remaining two
!defined(LIBRESSL_VERSION_NUMBER)paths in the source, theSSL_CTX_set_ciphersuites()function will become available in LibreSSL 3.4.x, so it would be nice if those could be weakened to&& (!defined(LIBRESSL_VERSION_NUMBER) || LIBRESSL_VERSION_NUMBER > 0x3040000fL).The text was updated successfully, but these errors were encountered: