New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete quoting for parameters of some CMake commands #4

Closed
elfring opened this Issue Mar 13, 2016 · 1 comment

Comments

Projects
None yet
2 participants
@elfring

elfring commented Mar 13, 2016

Some parameters (like "${SYSCONFDIR}" and "${mosquitto_SOURCE_DIR}") are passed to CMake commands in your build scripts without enclosing them by quotation marks. I see that these places will result in build difficulties if the contents of the used variables will contain special characters like semicolons.

I would recommend to apply advices from a wiki article.

@ralight ralight added this to the 1.4.9 milestone Mar 13, 2016

@ralight

This comment has been minimized.

Show comment
Hide comment
@ralight

ralight Mar 15, 2016

Contributor

Closed in the fixes branch.

Contributor

ralight commented Mar 15, 2016

Closed in the fixes branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment