New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting "connection_messages false" still logs a "New connection from X on port Y." message #537

Closed
cjmaynard opened this Issue Aug 30, 2017 · 2 comments

Comments

Projects
None yet
3 participants
@cjmaynard
Copy link

cjmaynard commented Aug 30, 2017

Regarding the connection_messages option, the mosquitto.conf man page reads:

   connection_messages [ true | false ]
       If set to true, the log will include entries when clients connect
       and disconnect. If set to false, these entries will not appear.

With the default of "connection_messages true", and using mosquitto_pub to test, I see messages like so:

1504137323: New connection from 127.0.0.1 on port 1883.
1504137323: New client connected from 127.0.0.1 as mosqpub|2501-test (c1, k60).
1504137323: Client mosqpub|2501-test disconnected.

... but with "connection_messages false", I still see this message:

1504137889: New connection from 127.0.0.1 on port 1883.

I would not expect to see that message when setting "connection_messages false".

@karlp

This comment has been minimized.

Copy link
Contributor

karlp commented Aug 30, 2017

the variable name is perhaps bad, in that it says connections, but the manual text says it's the logs on clients, and that's true? I'd probably generally agree though, that it's not the ideal behaviour

@toast-uz

This comment has been minimized.

Copy link
Contributor

toast-uz commented Sep 2, 2017

+1
I agree this option is not implemented consistently.

szarta added a commit to szarta/mosquitto that referenced this issue Nov 6, 2017

Fix for issue eclipse#537: should not log connection message if optio…
…n to log it disabled

Signed-off-by: Brandon Arrendondo <barrendo@gmail.com>

szarta added a commit to szarta/mosquitto that referenced this issue Nov 7, 2017

Additional fix for issue eclipse#537: connection_messages logging
Signed-off-by: Brandon Arrendondo <barrendo@gmail.com>

ralight added a commit that referenced this issue Dec 9, 2018

Don't print connect/disconnect messages when connection_messages false.
Closes #772. Closes #613. Closes #537.

Thanks to Christopher Maynard, Brandon Arrendondo, and qubeck.

@ralight ralight closed this in 89f3d7b Dec 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment