Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow broker to start when no .conf files are found in include_dir #566

Closed
marleau opened this issue Sep 28, 2017 · 3 comments
Closed

Allow broker to start when no .conf files are found in include_dir #566

marleau opened this issue Sep 28, 2017 · 3 comments
Labels
Component: mosquitto-broker Type: Bug
Milestone
1.5.3

Comments

@marleau
Copy link

marleau commented Sep 28, 2017

I recently came across an issue where the broker wouldn't start if the include_dir did not contain a .conf file. In my use case, the folder may not always have a .conf file because extra configuration is not always needed.

Please allow the broker to start when no external configuration files are found in the include_dir.
@toast-uz
Copy link
Contributor

toast-uz commented Sep 28, 2017 •
edited

I confirmed this issue.
On Windows, if the include_dir did not contain a .conf file, the broker said:

Error: Unable to open include_dir 'testing'.
Error found at test_include.conf:1.
Error: Unable to open configuration file.

While no problem on the same situation on Linux.

@toast-uz
Copy link
Contributor

I reconfirmed conf.c source file.

Mosquitto on Windows calls FindFirstFile Win32API to check existence of both of directory and *.conf files at the same time, while on Linux does opendir system call to check existence of directory only.

@ralight
Copy link
Contributor

ralight commented Sep 25, 2018

This is now fixed in my local branch and will be released shortly as part of 1.5.3.

@ralight ralight closed this as completed Sep 25, 2018
@ralight ralight added this to the 1.5.3 milestone Sep 25, 2018
ralight added a commit that referenced this issue Sep 27, 2018
@ralight
Fix Windows version not starting if include_dir did not contain any f…
588d39e 
…iles.

Closes #566.

Thanks to marleau.
ralight added a commit that referenced this issue Nov 8, 2018
@ralight
Fix Windows version not starting if include_dir did not contain any f…
84a356e 
…iles.

Closes #566.

Thanks to marleau.
@lock lock bot locked as resolved and limited conversation to collaborators Aug 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Component: mosquitto-broker Type: Bug
Projects
None yet
Milestone
1.5.3
Development

No branches or pull requests
3 participants
@ralight @marleau @toast-uz