New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow broker to start when no .conf files are found in include_dir #566

Closed
marleau opened this Issue Sep 28, 2017 · 3 comments

Comments

Projects
None yet
3 participants
@marleau

marleau commented Sep 28, 2017

I recently came across an issue where the broker wouldn't start if the include_dir did not contain a .conf file. In my use case, the folder may not always have a .conf file because extra configuration is not always needed.

Please allow the broker to start when no external configuration files are found in the include_dir.

@toast-uz

This comment has been minimized.

Show comment
Hide comment
@toast-uz

toast-uz Sep 28, 2017

Contributor

I confirmed this issue.
On Windows, if the include_dir did not contain a .conf file, the broker said:

Error: Unable to open include_dir 'testing'.
Error found at test_include.conf:1.
Error: Unable to open configuration file.

While no problem on the same situation on Linux.

Contributor

toast-uz commented Sep 28, 2017

I confirmed this issue.
On Windows, if the include_dir did not contain a .conf file, the broker said:

Error: Unable to open include_dir 'testing'.
Error found at test_include.conf:1.
Error: Unable to open configuration file.

While no problem on the same situation on Linux.

@toast-uz

This comment has been minimized.

Show comment
Hide comment
@toast-uz

toast-uz Sep 30, 2017

Contributor

I reconfirmed conf.c source file.

Mosquitto on Windows calls FindFirstFile Win32API to check existence of both of directory and *.conf files at the same time, while on Linux does opendir system call to check existence of directory only.

Contributor

toast-uz commented Sep 30, 2017

I reconfirmed conf.c source file.

Mosquitto on Windows calls FindFirstFile Win32API to check existence of both of directory and *.conf files at the same time, while on Linux does opendir system call to check existence of directory only.

@ralight

This comment has been minimized.

Show comment
Hide comment
@ralight

ralight Sep 25, 2018

Contributor

This is now fixed in my local branch and will be released shortly as part of 1.5.3.

Contributor

ralight commented Sep 25, 2018

This is now fixed in my local branch and will be released shortly as part of 1.5.3.

@ralight ralight closed this Sep 25, 2018

@ralight ralight added this to the 1.5.3 milestone Sep 25, 2018

ralight added a commit that referenced this issue Sep 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment