New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PATCH] lib/tls_mosq.h Detect PSK support / Fix build with LibreSSL #68

Closed
ralight opened this Issue Mar 15, 2016 · 0 comments

Comments

Projects
None yet
1 participant
@ralight
Copy link
Contributor

ralight commented Mar 15, 2016

migrated from Bugzilla #463366
status UNCONFIRMED severity normal in component Mosquitto for 1.4
Reported in version 1.3.x on platform PC
Assigned to: Roger Light

Original attachment names and IDs:

On 2015-03-28 15:03:48 -0400, Bernard Spil wrote:

Created attachment 251967
Unified diff for lib/tls_mosq.h

The check for PSK support (OpenSSL >= 1.0.0) is incomplete, PSK can be disabled and then results in OPENSSL_NO_PSK being set. With LibreSSL this is the default configuration. Attached patch fixes build with LibreSSL

On 2015-03-28 17:41:56 -0400, Roger Light wrote:

Thanks for the patch (I've not looked at it), if you would like it to be included you will need to follow the steps described at http://git.eclipse.org/c/mosquitto/org.eclipse.mosquitto.git/tree/CONTRIBUTING.md

On 2015-04-09 15:10:16 -0400, Roger Light wrote:

I've reviewed this with the Foundation staff. Could you please add a comment stating that you comply with the terms here: http://www.eclipse.org/legal/CoO.php

After you have done this I can accept the patch.

@ralight ralight added this to the 1.5.5 milestone Dec 9, 2018

@ralight ralight closed this Dec 9, 2018

ralight added a commit that referenced this issue Dec 9, 2018

ralight added a commit that referenced this issue Dec 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment