New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mosquitto_auth_plugin_cleanup never called by mosquitto? #900

Closed
JulianZhao opened this Issue Jul 31, 2018 · 2 comments

Comments

Projects
None yet
3 participants
@JulianZhao

JulianZhao commented Jul 31, 2018

mosquitto_plugin.h says:

Function: mosquitto_auth_plugin_cleanup
Called when the broker is shutting down. This will only ever be called once per plugin.
Note that <mosquitto_auth_security_cleanup> will be called directly before this function.

but I didn't find any code in mosquitto for this. plugin->plugin_cleanup_v3 is assigned but never called.

mosquitto_auth_security_cleanup is called normally.

@toast-uz

This comment has been minimized.

Show comment
Hide comment
@toast-uz

toast-uz Jul 31, 2018

Contributor

Did you have any actual failure in addition to the code review? Did your issue reproduce on plugin v3 only, or on any version?

Contributor

toast-uz commented Jul 31, 2018

Did you have any actual failure in addition to the code review? Did your issue reproduce on plugin v3 only, or on any version?

ralight added a commit that referenced this issue Aug 1, 2018

[Broker] Fix auth plugin cleanup function not being called.
Closes #900.

Thanks to Julian Zhao.

Signed-off-by: Roger A. Light <roger@atchoo.org>
@ralight

This comment has been minimized.

Show comment
Hide comment
@ralight

ralight Aug 1, 2018

Contributor

Thanks for reporting this, it should be fixed in the fixes branch now. If you could confirm and close the issue if it works for you.

Contributor

ralight commented Aug 1, 2018

Thanks for reporting this, it should be fixed in the fixes branch now. If you could confirm and close the issue if it works for you.

@ralight ralight added this to the 1.5.1 milestone Aug 1, 2018

@ralight ralight closed this Aug 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment