New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DYS-173: Adding support for QNX7.0.0 #1018

Merged
merged 1 commit into from Nov 6, 2018

Conversation

Projects
None yet
3 participants
@w0land
Contributor

w0land commented Nov 6, 2018

This change allows mosquitto to be compiled and used on QNX platform (qnx700).
My custom CMake toolchain adds CMake variable QNX ; additionally qcc (QNX compiler) adds __QNX__ macro that can be used in sources.

Signed-off-by: Bartosz Taczała bartosz.taczala@mobica.com

  • If you are contributing a new feature, is your work based off the develop branch?
  • If you are contributing a bugfix, is your work based off the fixes branch?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you successfully run make test with your changes locally?
  • Have you signed the Eclipse Contributor Agreement, using the same email address as you used in your commits?
  • Do each of your commits have a "Signed-off-by" line, with the correct email address? Use "git commit -s" to generate this line for you.

Show resolved Hide resolved client/CMakeLists.txt Outdated
@@ -115,7 +115,10 @@ endif (WIN32 OR CYGWIN)
add_definitions (-DWITH_BROKER)
set (MOSQ_LIBS ${MOSQ_LIBS} ${OPENSSL_LIBRARIES})
set (MOSQ_LIBS ${MOSQ_LIBS})
if(WITH_TLS)

This comment has been minimized.

@karlp

karlp Nov 6, 2018

Contributor

this seems like a standalone bug fix? ie, valid, but out of scope for a QNX support commit

This comment has been minimized.

@w0land

w0land Nov 6, 2018

Contributor

Ok, I'll create another PR for this

Show resolved Hide resolved src/CMakeLists.txt Outdated
Adding support for QNX7.0.0
Change-Id: Id01e2880aa5cadc0e93a46b95fe675e1938051fa
Signed-off-by: Bartosz Taczała <bartosz.taczala@mobica.com>
@karlp

This comment has been minimized.

Contributor

karlp commented Nov 6, 2018

looks sane to me, (one whitespace new line added) but I've not actually tested this or targetted qnx.

More interestingly, do the makefiles work? the cmakefiles are, per readme, only intended for windows /mac "On Windows and Mac, use cmake to build. On other platforms, just run make to build."

@ralight ralight added this to the 1.5.4 milestone Nov 6, 2018

@ralight ralight changed the base branch from master to fixes Nov 6, 2018

@ralight

This comment has been minimized.

Contributor

ralight commented Nov 6, 2018

I'm happy to take this as is, thanks for the contribution. Way back in the day (around 2012) I compiled mosquitto for QNX, but haven't touched it since. It's nice to see some more interest from that side.

Like Karl says, the bare Makefiles are intended as the canonical build scripts for the project, Mac and Windows not withstanding. I don't suppose it matters hugely, but it would be nice to hear if the build works with them as well.

@ralight ralight merged commit e86b27a into eclipse:fixes Nov 6, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
ip-validation
Details
@w0land

This comment has been minimized.

Contributor

w0land commented Nov 7, 2018

Oh.. Somehow I didn't catch that.
Makefiles doesn't work as they are trying to link againt rt and pthread that does not exists under QNX (functionality is simply a part of QNX's libc)

@ralight

This comment has been minimized.

Contributor

ralight commented Nov 7, 2018

There's nothing inherently wrong with using the cmake files, but the others are considered the best supported. For QNX I wouldn't worry particularly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment