New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for issue #537: should not log connection message if option disabled #613

Closed
wants to merge 5 commits into
base: fixes
from

Conversation

Projects
None yet
3 participants
@szarta
Copy link

szarta commented Nov 6, 2017

Added configuration check before printing connection message.

Signed-off-by: Brandon Arrendondo barrendo@gmail.com

Fix for issue #537: should not log connection message if option to lo…
…g it disabled

Signed-off-by: Brandon Arrendondo <barrendo@gmail.com>
@toast-uz

This comment has been minimized.

Copy link

toast-uz commented on 68963d6 Nov 7, 2017

I think there are many connection messages, while you fixed one. Search by MOSQ LOG_NOTICE on source files. Could you clarify the selection policy?

@szarta

This comment has been minimized.

Copy link

szarta commented Nov 7, 2017

I will test and find the other ones as well and include those in the pull request.

Additional fix for issue #537: connection_messages logging
Signed-off-by: Brandon Arrendondo <barrendo@gmail.com>
@szarta

This comment has been minimized.

Copy link

szarta commented Nov 7, 2017

The help for connection_messages logging states that it should affect all messages relating to clients connecting and disconnecting, so I found those and made sure they were wrapped appropriately.

szarta added some commits Nov 9, 2017

Fixed #621 - rewording regarding keepalive for the client
Signed-off-by: Brandon Arrendondo <barrendo@gmail.com>
@PierreF

This comment has been minimized.

Copy link
Contributor

PierreF commented Dec 23, 2017

I'm not convinced that all messages are connection related messages. The ACL denied message don't look connection related for me.
The message about expiring persistent also is not connection related in my opinion.

@ralight ralight force-pushed the eclipse:fixes branch from f22ea8c to 9d157f8 Aug 16, 2018

ralight added a commit that referenced this pull request Dec 9, 2018

Don't print connect/disconnect messages when connection_messages false.
Closes #772. Closes #613. Closes #537.

Thanks to Christopher Maynard, Brandon Arrendondo, and qubeck.

@ralight ralight closed this in 89f3d7b Dec 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment