New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NEW] log send UNSUBACK like send SUBACK as requested in #790 #903

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@ckrey

ckrey commented Jul 31, 2018

sample output:

1533053520: mosquitto version 1.5 starting
1533053520: Config loaded from /home/ckrey/mosquitto/mosquitto.conf.
1533053520: Opening ipv4 listen socket on port 1883.
1533053525: New connection from 10.0.2.2 on port 1883.
1533053525: New client connected from 10.0.2.2 as MQTTClient732328 (c1, k60).
1533053525: No will message specified.
1533053525: Sending CONNACK to MQTTClient732328 (0, 0)
1533053525: Received SUBSCRIBE from MQTTClient732328
1533053525: MQTTClient/# (QoS 2)
1533053525: MQTTClient732328 2 MQTTClient/#
1533053525: Sending SUBACK to MQTTClient732328
1533053528: Received UNSUBSCRIBE from MQTTClient732328
1533053528: MQTTClient/#
1533053528: MQTTClient732328 MQTTClient/#
1533053528: Sending UNSUBACK to MQTTClient732328
1533053532: Received DISCONNECT from MQTTClient732328
1533053532: Client MQTTClient732328 disconnected.
1533053536: mosquitto version 1.5 terminating

@ralight

This comment has been minimized.

Show comment
Hide comment
@ralight

ralight Aug 1, 2018

Contributor

This looks just fine, but could you please ensure you have signed the Eclipse Contributor Agreement https://www.eclipse.org/legal/ECA.php with the email you have used in your commit, and add a Signed-off-by line to our commit (use "git commit -s" as the easy option).

Alternatively, give me the nod and I'll just make this change myself.

Contributor

ralight commented Aug 1, 2018

This looks just fine, but could you please ensure you have signed the Eclipse Contributor Agreement https://www.eclipse.org/legal/ECA.php with the email you have used in your commit, and add a Signed-off-by line to our commit (use "git commit -s" as the easy option).

Alternatively, give me the nod and I'll just make this change myself.

@ckrey

This comment has been minimized.

Show comment
Hide comment
@ckrey

ckrey Aug 1, 2018

@ralight probably it would be the fastest path if you add the one line 😉

ckrey commented Aug 1, 2018

@ralight probably it would be the fastest path if you add the one line 😉

ralight added a commit that referenced this pull request Aug 9, 2018

Fix UNSUBACK messages not being logged.
Closes #903.

Thanks to Christoph Krey.

@ralight ralight added bug and removed enhancement labels Aug 9, 2018

@ralight ralight added this to the 1.5.1 milestone Aug 9, 2018

@ralight

This comment has been minimized.

Show comment
Hide comment
@ralight

ralight Aug 9, 2018

Contributor

Thanks, that's now fixed. I just didn't want to steal your glory!

Contributor

ralight commented Aug 9, 2018

Thanks, that's now fixed. I just didn't want to steal your glory!

@ralight ralight closed this Aug 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment