From f4a99dd144182d273f4aa629563c1042d24056ef Mon Sep 17 00:00:00 2001 From: Younes Manton Date: Wed, 13 Jan 2021 14:32:12 -0500 Subject: [PATCH] Remove inline from CCData static member funcs Declaring the functions inlined allows the compiler skip emitting callable symbols for them in `CCData.o`, but because the functions are declared in a header that's included in other compilation units the linker complains that there are no implementations for said functions available, even though they're declared private and not referenced outside of `CCData.o`. Unfortunately said functions need to be declared as class members because they refer to private typedefs in the CCData class. Signed-off-by: Younes Manton --- compiler/codegen/CCData.cpp | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/compiler/codegen/CCData.cpp b/compiler/codegen/CCData.cpp index 7e8dd772e65..186d1acecb9 100644 --- a/compiler/codegen/CCData.cpp +++ b/compiler/codegen/CCData.cpp @@ -1,5 +1,5 @@ /******************************************************************************* - * Copyright (c) 2020, 2020 IBM Corp. and others + * Copyright (c) 2020, 2021 IBM Corp. and others * * This program and the accompanying materials are made available under * the terms of the Eclipse Public License 2.0 which accompanies this @@ -29,19 +29,16 @@ using TR::CCData; -inline size_t CCData::dataSizeFromBytesSize(size_t sizeBytes) { return (sizeBytes + sizeof(data_t) - 1) / sizeof(data_t); } -inline size_t CCData::dataAlignmentFromBytesAlignment(size_t alignmentBytes) { return (alignmentBytes + OMR_ALIGNOF(data_t) - 1) / OMR_ALIGNOF(data_t); } -inline size_t CCData::byteIndexFromDataIndex(size_t dataIndex) { return dataIndex * sizeof(data_t);