Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upRelocated FrontEnd.hpp and modified relevent directives #4505
Conversation
Yuehan-Lin
requested review from
0xdaryl,
andrewcraik,
charliegracie,
fjeremic,
Leonardo2718,
mstoodle and
vijaysun-omr
as
code owners
This comment has been minimized.
This comment has been minimized.
|
@genie-omr build all |
Yuehan-Lin
force-pushed the
Yuehan-Lin:include2
branch
3 times, most recently
from
0c0a59a
to
2409033
This comment has been minimized.
This comment has been minimized.
|
@genie-omr build all |
Signed-off-by: Yuehan-Lin <Yuehan.Lin@ibm.com>
This comment has been minimized.
This comment has been minimized.
|
@genie-omr build all |
|
LGTM |
This comment has been minimized.
This comment has been minimized.
|
For some reason, the status of the Travis build is stale. I've manually checked the build it has passed successfully. All the other tests have also passed so I am going to merge this. |
Leonardo2718
merged commit 87bb94e
into
eclipse:master
13 of 14 checks passed
13 of 14 checks passed
eclipsefdn/eca
The author(s) of the pull request is covered by necessary legal agreements in order to proceed!
Details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Yuehan-Lin commentedOct 23, 2019
Issue: #4504
Could be built on Linux, ready for tests
Signed-off-by: Yuehan-Lin Yuehan.Lin@ibm.com