Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add omrstr_convert target code page CP_ACP/CP_THREAD_ACP #4525

Merged
merged 1 commit into from Nov 1, 2019

Conversation

@JasonFengJ9
Copy link
Contributor

JasonFengJ9 commented Oct 30, 2019

Add omrstr_convert target code page CP_ACP/CP_THREAD_ACP

Added target encoding J9STR_CODE_WINDEFAULTACP/J9STR_CODE_WINTHREADACP for Windows code page CP_ACP/CP_THREAD_ACP.

required by: eclipse/openj9#7607

Verified that this PR along with eclipse/openj9#7607 fix eclipse/openj9#6722.

FYI: @DanHeidinga @pshipton

Signed-off-by: Jason Feng fengj@ca.ibm.com

@JasonFengJ9

This comment has been minimized.

Copy link
Contributor Author

JasonFengJ9 commented Oct 30, 2019

@rwy0717 could you arrange a review?

@rwy0717 rwy0717 self-assigned this Oct 30, 2019
@rwy0717 rwy0717 added the comp:port label Oct 30, 2019
@rwy0717

This comment has been minimized.

Copy link
Member

rwy0717 commented Oct 30, 2019

@genie-omr build all

Added target encoding J9STR_CODE_WINDEFAULTACP/J9STR_CODE_WINTHREADACP
for Windows code page CP_ACP/CP_THREAD_ACP.

Signed-off-by: Jason Feng <fengj@ca.ibm.com>
@JasonFengJ9 JasonFengJ9 force-pushed the JasonFengJ9:localepath branch from 7f7c97c to 1fc5b76 Nov 1, 2019
@rwy0717

This comment has been minimized.

Copy link
Member

rwy0717 commented Nov 1, 2019

@genie-omr build all

@rwy0717
rwy0717 approved these changes Nov 1, 2019
@rwy0717 rwy0717 merged commit 5086b80 into eclipse:master Nov 1, 2019
14 checks passed
14 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/eclipse-omr/pr/aix_ppc-64 Build finished.
Details
continuous-integration/eclipse-omr/pr/linux_390-64 Build finished.
Details
continuous-integration/eclipse-omr/pr/linux_aarch64 Build finished.
Details
continuous-integration/eclipse-omr/pr/linux_arm Build finished.
Details
continuous-integration/eclipse-omr/pr/linux_ppc-64_le_gcc Build finished.
Details
continuous-integration/eclipse-omr/pr/linux_x86 Build finished.
Details
continuous-integration/eclipse-omr/pr/linux_x86-64 Build finished.
Details
continuous-integration/eclipse-omr/pr/linux_x86-64_cmprssptrs Build finished.
Details
continuous-integration/eclipse-omr/pr/osx_x86-64 Build finished.
Details
continuous-integration/eclipse-omr/pr/win_x86-64 Build finished.
Details
continuous-integration/eclipse-omr/pr/zos_390-64 Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
eclipsefdn/eca The author(s) of the pull request is covered by necessary legal agreements in order to proceed!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.