Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ASTToTRNode class to refactor Tril ilgen #4608

Merged
merged 2 commits into from Dec 17, 2019

Conversation

@Yuehan-Lin
Copy link
Contributor

Yuehan-Lin commented Nov 27, 2019

Refactored Tril ilgen ToTRNode to use ASTToTRNode class, and changes are made to the followings:

  • Defined private copy constructor for TypeDictionary class
  • Added ASTToTRNode, its subclasses and each exception classes to make it be extensible
  • Added IlGenState class to store the maps get from TRLangBuilder, and values in IlInjector
Signed-off-by: Yuehan-Lin <Yuehan.Lin@ibm.com>
fvtest/tril/tril/ConvertBlanket.hpp Outdated Show resolved Hide resolved
fvtest/tril/tril/ilgen.cpp Show resolved Hide resolved
fvtest/tril/tril/ilgen.hpp Show resolved Hide resolved
fvtest/tril/tril/ilgen.cpp Outdated Show resolved Hide resolved
fvtest/tril/tril/ilgen.hpp Outdated Show resolved Hide resolved
fvtest/tril/tril/ConvertCall.hpp Outdated Show resolved Hide resolved
fvtest/tril/tril/converter.hpp Outdated Show resolved Hide resolved
fvtest/tril/tril/converter.hpp Outdated Show resolved Hide resolved
fvtest/tril/tril/converter.hpp Outdated Show resolved Hide resolved
fvtest/tril/tril/state.hpp Outdated Show resolved Hide resolved
@Yuehan-Lin Yuehan-Lin force-pushed the Yuehan-Lin:ilgen2 branch from dc307c2 to 1f2f878 Dec 10, 2019
fvtest/tril/test/IlGenTest.cpp Outdated Show resolved Hide resolved
fvtest/tril/tril/GenericNodeConverter.hpp Outdated Show resolved Hide resolved
@Yuehan-Lin Yuehan-Lin force-pushed the Yuehan-Lin:ilgen2 branch 2 times, most recently from d13895d to dd91088 Dec 16, 2019
fvtest/tril/test/IlGenTest.cpp Outdated Show resolved Hide resolved
@Yuehan-Lin Yuehan-Lin force-pushed the Yuehan-Lin:ilgen2 branch from dd91088 to 3e2a4ba Dec 17, 2019
fvtest/tril/test/IlGenTest.cpp Outdated Show resolved Hide resolved
Signed-off-by: Yuehan-Lin <Yuehan.Lin@ibm.com>
@Yuehan-Lin Yuehan-Lin force-pushed the Yuehan-Lin:ilgen2 branch from 3e2a4ba to 0c82527 Dec 17, 2019
Copy link
Contributor

Leonardo2718 left a comment

LGTM 👍

@Leonardo2718

This comment has been minimized.

Copy link
Contributor

Leonardo2718 commented Dec 17, 2019

@genie-omr build all

@Leonardo2718 Leonardo2718 merged commit 45d961a into eclipse:master Dec 17, 2019
14 checks passed
14 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/eclipse-omr/pr/aix_ppc-64 Build finished.
Details
continuous-integration/eclipse-omr/pr/linux_390-64 Build finished.
Details
continuous-integration/eclipse-omr/pr/linux_aarch64 Build finished.
Details
continuous-integration/eclipse-omr/pr/linux_arm Build finished.
Details
continuous-integration/eclipse-omr/pr/linux_ppc-64_le_gcc Build finished.
Details
continuous-integration/eclipse-omr/pr/linux_x86 Build finished.
Details
continuous-integration/eclipse-omr/pr/linux_x86-64 Build finished.
Details
continuous-integration/eclipse-omr/pr/linux_x86-64_cmprssptrs Build finished.
Details
continuous-integration/eclipse-omr/pr/osx_x86-64 Build finished.
Details
continuous-integration/eclipse-omr/pr/win_x86-64 Build finished.
Details
continuous-integration/eclipse-omr/pr/zos_390-64 Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
eclipsefdn/eca The author(s) of the pull request is covered by necessary legal agreements in order to proceed!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.