Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move arithmeticNeedsLiteralFromPool function from OMR to OpenJ9 #4616

Merged
merged 1 commit into from Dec 3, 2019

Conversation

@mhaque5
Copy link
Contributor

mhaque5 commented Nov 28, 2019

Move arithmeticNeedsLiteralFromPool function from OMR to OpenJ9

This commit moves arithmeticNeedsLiteralFromPool function from OMR to
OpenJ9. arithmeticNeedsLiteralFromPool is not used in OMR, but it is
used in OpenJ9 for Z codegen implementation.

Fixes: #1870
Signed-off-by: Md. Ariful Haque mhaque5@unb.ca

This commit moves arithmeticNeedsLiteralFromPool function from OMR to
OpenJ9. arithmeticNeedsLiteralFromPool is not used in OMR, but it is
used in OpenJ9 for Z codegen implementation.

Fixes: #1870
Signed-off-by: Md. Ariful Haque <mhaque5@unb.ca>
@fjeremic

This comment has been minimized.

Copy link
Contributor

fjeremic commented Dec 2, 2019

@mhaque5 can you link the OpenJ9 PR which moves the code over for future reference?

@mhaque5

This comment has been minimized.

Copy link
Contributor Author

mhaque5 commented Dec 2, 2019

@mhaque5 can you link the OpenJ9 PR which moves the code over for future reference?

@fjeremic Link has been added.

@fjeremic fjeremic self-assigned this Dec 2, 2019
@fjeremic

This comment has been minimized.

Copy link
Contributor

fjeremic commented Dec 2, 2019

@genie-omr build all

@fjeremic

This comment has been minimized.

Copy link
Contributor

fjeremic commented Dec 2, 2019

The AIX failure is due to #4539 / #4594 and ARM failure is the same one seen in #4568 so I think we're good to go here (reinforced by the fact this is effectively a Z only change). @mhaque5 please tag me in a comment once you remove the WIP and this one is ready to be merged.

@mhaque5 mhaque5 changed the title WIP: Move arithmeticNeedsLiteralFromPool function from OMR to OpenJ9 Move arithmeticNeedsLiteralFromPool function from OMR to OpenJ9 Dec 3, 2019
@mhaque5

This comment has been minimized.

Copy link
Contributor Author

mhaque5 commented Dec 3, 2019

The AIX failure is due to #4539 / #4594 and ARM failure is the same one seen in #4568 so I think we're good to go here (reinforced by the fact this is effectively a Z only change). @mhaque5 please tag me in a comment once you remove the WIP and this one is ready to be merged.

@fjeremic I have removed the WIP.

@fjeremic fjeremic merged commit c2d2ad8 into eclipse:master Dec 3, 2019
12 of 14 checks passed
12 of 14 checks passed
continuous-integration/eclipse-omr/pr/aix_ppc-64 Build finished.
Details
continuous-integration/eclipse-omr/pr/linux_arm Build finished.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/eclipse-omr/pr/linux_390-64 Build finished.
Details
continuous-integration/eclipse-omr/pr/linux_aarch64 Build finished.
Details
continuous-integration/eclipse-omr/pr/linux_ppc-64_le_gcc Build finished.
Details
continuous-integration/eclipse-omr/pr/linux_x86 Build finished.
Details
continuous-integration/eclipse-omr/pr/linux_x86-64 Build finished.
Details
continuous-integration/eclipse-omr/pr/linux_x86-64_cmprssptrs Build finished.
Details
continuous-integration/eclipse-omr/pr/osx_x86-64 Build finished.
Details
continuous-integration/eclipse-omr/pr/win_x86-64 Build finished.
Details
continuous-integration/eclipse-omr/pr/zos_390-64 Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
eclipsefdn/eca The author(s) of the pull request is covered by necessary legal agreements in order to proceed!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.