Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake: Refactor DDR support #4648

Merged
merged 1 commit into from Dec 7, 2019
Merged

CMake: Refactor DDR support #4648

merged 1 commit into from Dec 7, 2019

Conversation

@dnakamura
Copy link
Contributor

dnakamura commented Dec 6, 2019

  • Move the OMR_SEPARATE_DEBUG_INFO flag into OmrDDRSupport as consumers
    may start using ddr before including omr
  • Fix typo in osx split debug info support dysymutil->dsymutil
  • Force use of split debug info on osx, as debug info is not stored in
    libraries (needs to be extracted from input objects)

Signed-off-by: Devin Nakamura devinn@ca.ibm.com

- Move the OMR_SEPARATE_DEBUG_INFO flag into OmrDDRSupport as consumers
  may start using ddr before including omr
- Fix typo in osx split debug info support dysymutil->dsymutil
- Force use of split debug info on osx, as debug info is not stored in
  libraries (needs to be extracted from input objects)

Signed-off-by: Devin Nakamura <devinn@ca.ibm.com>
@dnakamura

This comment has been minimized.

Copy link
Contributor Author

dnakamura commented Dec 6, 2019

@genie-omr build all

1 similar comment
@dnakamura

This comment has been minimized.

Copy link
Contributor Author

dnakamura commented Dec 6, 2019

@genie-omr build all

@Leonardo2718 Leonardo2718 added the cmake label Dec 6, 2019
@rwy0717
rwy0717 approved these changes Dec 7, 2019
@rwy0717 rwy0717 merged commit bc39bc3 into eclipse:master Dec 7, 2019
14 checks passed
14 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/eclipse-omr/pr/aix_ppc-64 Build finished.
Details
continuous-integration/eclipse-omr/pr/linux_390-64 Build finished.
Details
continuous-integration/eclipse-omr/pr/linux_aarch64 Build finished.
Details
continuous-integration/eclipse-omr/pr/linux_arm Build finished.
Details
continuous-integration/eclipse-omr/pr/linux_ppc-64_le_gcc Build finished.
Details
continuous-integration/eclipse-omr/pr/linux_x86 Build finished.
Details
continuous-integration/eclipse-omr/pr/linux_x86-64 Build finished.
Details
continuous-integration/eclipse-omr/pr/linux_x86-64_cmprssptrs Build finished.
Details
continuous-integration/eclipse-omr/pr/osx_x86-64 Build finished.
Details
continuous-integration/eclipse-omr/pr/win_x86-64 Build finished.
Details
continuous-integration/eclipse-omr/pr/zos_390-64 Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
eclipsefdn/eca The author(s) of the pull request is covered by necessary legal agreements in order to proceed!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.