New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't use once read symbol heuristics in UseDef at warm #6093
Conversation
Jenkins build all |
Made WIP since I still need to run through personal build.. |
Jenkins build all |
Could we improve the commit message with a reason why this change is being made, or at the very least add a comment to this PR explaining things? I can see someone looking up the history of this change in the future and wondering what drove us to make this change. Also for PRs with one commit we should try to keep the commit title the same as the PR title (+ sentence case capitalization of first work for consistency with other commits). |
- Use onceReadSymbolsIndices at < warm since it helps performance without considerably increasing compile time
I can also see that :) Fixed. |
Jenkins build all |
Please don't merge yet. I found a personal build failure that I need to debug. |
I think it was unrelated failure. Please merge if there are no other issues. |
Heuristic change that looks fine to me and is backed up by data. Checks have passed. Merging. |
Don't use once read symbol heuristics in UseDef at warm