Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure AOT compilation in jitdump #10962

Open
1 of 3 tasks
dsouzai opened this issue Oct 21, 2020 · 3 comments
Open
1 of 3 tasks

Ensure AOT compilation in jitdump #10962

dsouzai opened this issue Oct 21, 2020 · 3 comments

Comments

@dsouzai
Copy link
Contributor

dsouzai commented Oct 21, 2020

If a crash happens in an AOT body, the jitdump should generate an AOT compilation. However, this is not as trivial as it might seem, as there are three scenarios:

  • 1. Crash during an AOT compile - Ensure AOT Compilation in JIT Dump #10852
  • 2. Crash in an AOT body that was generated in the current JVM instance
  • 3. Crash in an AOT body that was generated in a different JVM instance

Regarding 2, should the jitdump redo the AOT compilation, the AOT load, or both?
Regarding 3, should the jitdump redo the AOT load?


@dsouzai
Copy link
Contributor Author

dsouzai commented Oct 21, 2020

fyi @mpirvu @fjeremic

@mpirvu
Copy link
Contributor

mpirvu commented Oct 22, 2020

I wonder about the value of [3] since typically we want to get to compilation logs.
Moreover, the advantage of jitdump is that it can generate a log from the the same JDK that produced the bad jitted body. If the AOT body has been produced in a previous run, we lose that advantage, so a compilation log from a brand new JVM invocation may be just as good.

Regarding 2, should the jitdump redo the AOT compilation, the AOT load, or both?

I think we want to redo the AOT compilation.

@dsouzai dsouzai closed this as completed Oct 27, 2020
@dsouzai dsouzai reopened this Oct 27, 2020
@dsouzai
Copy link
Contributor Author

dsouzai commented Oct 27, 2020

^T'was by accident

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants