Modify HeapRegionDescriptorRealtime for moving into OMR #5125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
please fix copyrights |
| @@ -108,7 +108,7 @@ MM_RealtimeGCDelegate::allocateAndInitializeReferenceObjectLists(MM_EnvironmentB | |||
| bool | |||
| MM_RealtimeGCDelegate::allocateAndInitializeUnfinalizedObjectLists(MM_EnvironmentBase *env) | |||
| { | |||
| const UDATA listCount = MM_HeapRegionDescriptorRealtime::getUnfinalizedObjectListCount(env); | |||
| const UDATA listCount = MM_RealtimeGCDelegate::getUnfinalizedObjectListCount(env); | |||
There was a problem hiding this comment.
There is no need to specify MM_RealtimeGCDelegate:: here. This is a member of this class
| @@ -132,7 +132,7 @@ MM_RealtimeGCDelegate::allocateAndInitializeUnfinalizedObjectLists(MM_Environmen | |||
| bool | |||
| MM_RealtimeGCDelegate::allocateAndInitializeOwnableSynchronizerObjectLists(MM_EnvironmentBase *env) | |||
| { | |||
| const UDATA listCount = MM_HeapRegionDescriptorRealtime::getOwnableSynchronizerObjectListCount(env); | |||
| const UDATA listCount = MM_RealtimeGCDelegate::getOwnableSynchronizerObjectListCount(env); | |||
There was a problem hiding this comment.
There is no need to specify MM_RealtimeGCDelegate:: here. This is a member of this class
| @@ -117,6 +117,10 @@ class MM_RealtimeGCDelegate : public MM_BaseNonVirtual | |||
| void lockClassUnloadMonitor(MM_EnvironmentRealtime *env); | |||
| void unlockClassUnloadMonitor(MM_EnvironmentRealtime *env); | |||
|
|
|||
| static UDATA getUnfinalizedObjectListCount(MM_EnvironmentBase *env) {return MM_GCExtensions::getExtensions(env)->gcThreadCount;} | |||
| static UDATA getOwnableSynchronizerObjectListCount(MM_EnvironmentBase *env) {return MM_GCExtensions::getExtensions(env)->gcThreadCount;} | |||
| static UDATA getReferenceObjectListCount(MM_EnvironmentBase *env) {return MM_GCExtensions::getExtensions(env)->gcThreadCount;} | |||
There was a problem hiding this comment.
_extensions can be used instead of MM_GCExtensions::getExtensions(env)
jason-hall
force-pushed
the
metronome14
branch
3 times, most recently
from
324a7c4
to
67757a0
Compare
| @@ -117,6 +117,10 @@ class MM_RealtimeGCDelegate : public MM_BaseNonVirtual | |||
| void lockClassUnloadMonitor(MM_EnvironmentRealtime *env); | |||
| void unlockClassUnloadMonitor(MM_EnvironmentRealtime *env); | |||
|
|
|||
| UDATA getUnfinalizedObjectListCount(MM_EnvironmentBase *env) { return MM_GCExtensions::getExtensions(env)->gcThreadCount; } | |||
| UDATA getOwnableSynchronizerObjectListCount(MM_EnvironmentBase *env) { return MM_GCExtensions::getExtensions(env)->gcThreadCount; } | |||
| UDATA getReferenceObjectListCount(MM_EnvironmentBase *env) { return MM_GCExtensions::getExtensions(env)->gcThreadCount; } | |||
There was a problem hiding this comment.
now you can use _extensions instead of MM_GCExtensions::getExtensions(env)
| @@ -1021,7 +1027,7 @@ MM_RealtimeMarkingScheme::incrementalConsumeQueue(MM_EnvironmentRealtime *env, U | |||
| void | |||
| MM_RealtimeMarkingScheme::scanUnfinalizedObjects(MM_EnvironmentRealtime *env) | |||
| { | |||
| const UDATA maxIndex = MM_HeapRegionDescriptorRealtime::getUnfinalizedObjectListCount(env); | |||
| const UDATA maxIndex = _gcExtensions->realtimeGC->getRealtimeDelegate()->getUnfinalizedObjectListCount(env); | |||
There was a problem hiding this comment.
you can use _realtimeGC here and below
Signed-off-by: Jason Hall <jasonhal@ca.ibm.com>
dmitripivkine
approved these changes
Mar 19, 2019
|
Jenkins compile win |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jason Hall jasonhal@ca.ibm.com