Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable SVM during Startup #5180

Merged
merged 1 commit into from Mar 21, 2019
Merged

Conversation

dsouzai
Copy link
Contributor

@dsouzai dsouzai commented Mar 20, 2019

Mild admission of defeat, but since there are issues in startup on multiple platforms in Java 11, this is a temporary solution until a better one is implemented. For the most part it seems the reason SVM regresses startup is because of increased load failures that comes from compiling at invocation count 1000 (or 250) but loading at invocation count 20 (#4897).

Signed-off-by: Irwin D'Souza <dsouzai@ca.ibm.com>
@dsouzai
Copy link
Contributor Author

dsouzai commented Mar 20, 2019

FYI @vijaysun-omr

@mpirvu could you please review?

Copy link
Contributor

@mpirvu mpirvu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I guess this is a 'temporary' change until we get a better handle on AOT load failures.

@mpirvu mpirvu self-assigned this Mar 20, 2019
@dsouzai
Copy link
Contributor Author

dsouzai commented Mar 20, 2019

jenkins test sanity all jdk8,jdk11

@dsouzai
Copy link
Contributor Author

dsouzai commented Mar 21, 2019

@mpirvu all failures were infra failures. For three of them the tests passed but the jenkins job failed; the last job failed because of

error: RPC failed; curl 18 transfer closed with outstanding read data remaining
fatal: The remote end hung up unexpectedly
fatal: early EOF
fatal: index-pack failed

This should be ok to merge now.

@mpirvu mpirvu merged commit c510f91 into eclipse-openj9:master Mar 21, 2019
@dsouzai dsouzai deleted the svmStartup branch June 25, 2019 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants