(v0.14.0) Increment the SharedClasses cache generation number #5434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The copyright check failed. |
pshipton
approved these changes
Apr 13, 2019
|
@DanHeidinga can you please fix the copyright. |
When new bytecodes were added in eclipse-openj9#1831 for the truncated returns, the SCC generation number wasn't incremented which can lead to crashes. Currently the VM will attempt to destroy and recreate the SCC if the SHA in the header is different but if can't, it will continue to use the cache. The only sure way (today) to prevent this issue is to increment the cache generation. Do this now to prevent VerifyErrors due to unknown bytecodes while we work out the right behaviour. issue: eclipse-openj9#5380 Signed-off-by: Dan Heidinga <daniel_heidinga@ca.ibm.com>
DanHeidinga
force-pushed
the
djh/cachgen_v014
branch
from
583804c
to
366d213
Compare
|
Copyright now fixed |
pshipton
approved these changes
Apr 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Port from
masterbranch #5422)When new bytecodes were added in #1831 for the truncated returns,
the SCC generation number wasn't incremented which can lead to
crashes.
Currently the VM will attempt to destroy and recreate the SCC
if the SHA in the header is different but if can't, it will
continue to use the cache.
The only sure way (today) to prevent this issue is to increment
the cache generation.
Do this now to prevent VerifyErrors due to unknown bytecodes
while we work out the right behaviour.
issue: #5380
Signed-off-by: Dan Heidinga daniel_heidinga@ca.ibm.com