Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Static value type tests #7100

Merged
merged 1 commit into from Sep 26, 2019
Merged

Conversation

@XxAdi101xX
Copy link
Contributor

XxAdi101xX commented Sep 16, 2019

These changes introduce value type tests for static fields

Signed-off-by: Adithya Venkatarao adi_101@live.com

@XxAdi101xX

This comment has been minimized.

Copy link
Contributor Author

XxAdi101xX commented Sep 16, 2019

@tajila tests are passing locally, changes are ready for review

@XxAdi101xX XxAdi101xX force-pushed the XxAdi101xX:static-value-type-tests branch 2 times, most recently from 6ced752 to d44389c Sep 19, 2019
@XxAdi101xX

This comment has been minimized.

Copy link
Contributor Author

XxAdi101xX commented Sep 24, 2019

@tajila, I changed the locals for both the static getters to 0, pls re-review

@tajila
tajila approved these changes Sep 24, 2019
@tajila

This comment has been minimized.

Copy link
Contributor

tajila commented Sep 24, 2019

@llxia Please review these changes

@XxAdi101xX XxAdi101xX force-pushed the XxAdi101xX:static-value-type-tests branch from a7db621 to 0e61517 Sep 24, 2019
@llxia llxia added the comp:test label Sep 25, 2019
@llxia

This comment has been minimized.

Copy link
Contributor

llxia commented Sep 26, 2019

Waiting for #7235 to be merged, so we can run a test build.

@XxAdi101xX XxAdi101xX force-pushed the XxAdi101xX:static-value-type-tests branch 3 times, most recently from 6ad8d87 to 61f6814 Sep 26, 2019
Signed-off-by: Adithya Venkatarao <adi_101@live.com>
@XxAdi101xX XxAdi101xX force-pushed the XxAdi101xX:static-value-type-tests branch from 61f6814 to efb1605 Sep 26, 2019
@llxia
llxia approved these changes Sep 26, 2019
Copy link
Contributor

llxia left a comment

LGTM. Thanks for the internal testing.

@llxia

This comment has been minimized.

Copy link
Contributor

llxia commented Sep 26, 2019

Will forgo the PR builds as this is Valhalla test change.

@llxia llxia merged commit c53eece into eclipse:master Sep 26, 2019
3 checks passed
3 checks passed
Copyright Check Copyrights appear to be up to date
Details
Line Endings Check Line endings appear to be correct
Details
eclipsefdn/eca The author(s) of the pull request is covered by necessary legal agreements in order to proceed!
Details
@XxAdi101xX XxAdi101xX deleted the XxAdi101xX:static-value-type-tests branch Sep 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.