New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Guide for Committers doc #7175
Conversation
Might need to add something along the lines of ensuring |
I misread that the first time as 'added' not 'removed', and agreed those points should be included. There isn't a reference to the OMR guidelines which would make them redundant, so why are they removed? |
I too think the removed points should be included. Having had experience on the OMR side I generally find the two middle points to be quite helpful from both a contributor and a committer point of view:
These effectively give ownership of the PR to a single person who may have context about the PR which other committers may not be aware about. This includes coordination with other repositories (OMR, ibmruntimes, OpenJDK, Adopt, etc.). It also gives the contributor a single person to "nudge" in case all the reviews in the PR have been addressed and the contributor is effectively waiting for a committer to pick up the PR and drive it into the repository. |
No real reason other than the fact that I hadn't seen us committers do that on OpenJ9. However, seeing as there's interest to be more rigorous, I'll add those in. |
@fjeremic @keithc-ca @DanHeidinga Updated the doc with the requested changes; could you take a look again? |
Updated with requested changes. |
I figure we can wait until Friday to see if there are any other comments/concerns before merging as I've brought this up on slack multiple times now. Does that sound reasonable @fjeremic ? |
Agreed. Will merge by EOW unless other review requests are made. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
[ci skip] Based on https://github.com/eclipse/omr/blob/master/doc/GuideForCommitters.md Signed-off-by: Irwin D'Souza <dsouzai.gh@gmail.com>
I think we are good to go here. Thanks @dsouzai! |
Based on https://github.com/eclipse/omr/blob/master/doc/GuideForCommitters.md
I removed the following:These points are now in the doc based on #7175 (comment) and #7175 (comment)