Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhanced checkcast instruction to throw NPE on a value type cast on null #7419

Merged
merged 1 commit into from Oct 10, 2019

Conversation

@XxAdi101xX
Copy link
Contributor

XxAdi101xX commented Oct 9, 2019

Fixes the issues from #7210
Signed-off-by: Adithya Venkatarao adi_101@live.com

Signed-off-by: Adithya Venkatarao <adi_101@live.com>
@XxAdi101xX

This comment has been minimized.

Copy link
Contributor Author

XxAdi101xX commented Oct 9, 2019

@gacholio Personal build has passed on x86-64_linux and windows x86-64. The Valhalla tests have also been successful. The only diff since the last merge is the ifdef around the resolve label. Sorry about the confusion :)

@gacholio

This comment has been minimized.

Copy link
Contributor

gacholio commented Oct 9, 2019

jenkins test sanity win jdk11

@tajila

This comment has been minimized.

Copy link
Contributor

tajila commented Oct 9, 2019

The failure is a likely a file system issue.

15:45:55  c:\Users\jenkins\workspace\Build_JDK11_x86-64_windows_Personal\build\windows-x86_64-normal-server-release\support\gensrc\java.base\java\nio\channels\UnresolvedAddressException.java:31: error: class, interface, or enum expected
15:45:55      public UnresolvedAddressException() { }
15:45:55             ^
15:45:55  1 error

The class UnresolvedAddressException is not actually part of the java\nio\channels package in java11

https://github.com/ibmruntimes/openj9-openjdk-jdk11/tree/openj9/src/java.base/share/classes/java/nio/channels

@gacholio

This comment has been minimized.

Copy link
Contributor

gacholio commented Oct 10, 2019

Agreed - the C code compiled, and the tests don't run in PR builds, so I'll merge.

@gacholio gacholio merged commit 96c393f into eclipse:master Oct 10, 2019
4 of 6 checks passed
4 of 6 checks passed
Build_JDK11_x86-64_windows_Personal Build FAILED
Details
Pull Request - OpenJ9
Details
Copyright Check Copyrights appear to be up to date
Details
Line Endings Check Line endings appear to be correct
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
eclipsefdn/eca The author(s) of the pull request is covered by necessary legal agreements in order to proceed!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.