Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ACMP compatibility for value types #8133

Open
wants to merge 1 commit into
base: master
from

Conversation

@XxAdi101xX
Copy link
Contributor

XxAdi101xX commented Dec 17, 2019

This commit adds the implementation to handle value types when the ACMP bytecode is used to compare object fields. An ACMP optimization is also added and depends on the flag defined in #7743.

Signed-off-by: Adithya Venkatarao adi_101@live.com

@XxAdi101xX XxAdi101xX force-pushed the XxAdi101xX:acmp-integration-for-valuetypes branch from b1e171b to 513824e Dec 17, 2019
@XxAdi101xX XxAdi101xX force-pushed the XxAdi101xX:acmp-integration-for-valuetypes branch 3 times, most recently from 7b364fb to 4144c17 Dec 17, 2019
@XxAdi101xX

This comment has been minimized.

Copy link
Contributor Author

XxAdi101xX commented Dec 18, 2019

Duplicate of #7750

runtime/vm/valueTypeHelpers.hpp Outdated Show resolved Hide resolved
runtime/vm/valueTypeHelpers.hpp Outdated Show resolved Hide resolved
runtime/vm/valueTypeHelpers.hpp Outdated Show resolved Hide resolved
@XxAdi101xX XxAdi101xX force-pushed the XxAdi101xX:acmp-integration-for-valuetypes branch 2 times, most recently from 642e9b9 to 37bc808 Dec 18, 2019
runtime/vm/valueTypeHelpers.hpp Outdated Show resolved Hide resolved
This commit adds the implementation to handle value types when the ACMP bytecode is used to compare object fields. An ACMP optimization is also added and depends on the flag defined in #7743.

Signed-off-by: Adithya Venkatarao <adi_101@live.com>
@XxAdi101xX XxAdi101xX force-pushed the XxAdi101xX:acmp-integration-for-valuetypes branch from 37bc808 to 77efa38 Dec 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.