Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsolete specs from config files #8918

Merged
merged 1 commit into from Mar 20, 2020

Conversation

gacholio
Copy link
Contributor

Remove the purec and codecov configurations.

[ci skip]

Signed-off-by: Graham Chapman graham_chapman@ca.ibm.com

Remove the purec and codecov configurations.

[ci skip]

Signed-off-by: Graham Chapman <graham_chapman@ca.ibm.com>
@DanHeidinga
Copy link
Member

Did any of these specs end up in the cmake files? cc @dnakamura

@DanHeidinga DanHeidinga self-assigned this Mar 19, 2020
@gacholio
Copy link
Contributor Author

OMR also has some of these specs.

@DanHeidinga
Copy link
Member

DanHeidinga commented Mar 19, 2020

OMR also has some of these specs.

I don't think there's a dependency between the two projects as the specs aren't used. It would be good to remove them there as well though

@gacholio
Copy link
Contributor Author

Definitely no dependency - the specs are in the example only.

Copy link
Member

@DanHeidinga DanHeidinga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@DanHeidinga
Copy link
Member

merging without a build as these specs are never built anyway

@DanHeidinga DanHeidinga merged commit d1eb4ed into eclipse-openj9:master Mar 20, 2020
@gacholio gacholio deleted the specs branch March 20, 2020 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants