Bug 519611 - [lsp] DocumentHighlightKind is ignored for 'textDocument…

…/documentHighlight' requests

When processing the returned DocumentHighlight[] from the server, use
its kind property to determine whether we should mark it in Orion as
a read or write occurrence.

Signed-off-by: Remy Suen <remy.suen@gmail.com>

bundles/org.eclipse.orion.client.ui/web/orion/lsp/ipc.js

@@ -22,6 +22,16 @@ define([], function() {
 		Incremental: 2
 	});
 
+	/**
+	 * The object of codes for a DocumentHighlight to indicate what
+	 * what kind of highlighting it is.
+	 */
+	IPC.prototype.DOCUMENT_HIGHLIGHT_KIND = Object.freeze({
+		None: 1,
+		Read: 2,
+		Write: 3
+	});
+
 	/**
 	 * The object of error codes
 	 * @see https://github.com/Microsoft/language-server-protocol/blob/master/protocol.md#response-message

bundles/org.eclipse.orion.client.ui/web/orion/lsp/utils.js

@@ -81,7 +81,8 @@ define([
 					var offset = editor.getLineStart(result.range.start.line);
 					return {
 						start: result.range.start.character+offset,
-						end: result.range.end.character+offset
+						end: result.range.end.character+offset,
+						readAccess: result.kind === lspProviderImpl.ipc.DOCUMENT_HIGHLIGHT_KIND.Read
 					};
 				});
 			}