Bug 518685 - [lsp] Orion assumes that textDocument/completion request…

…s will always return a CompletionList

As textDocument/completion responses from the server can come in the
form of a CompletionList or a CompletionItem[], we should check which
type has been returned instead of assuming that it is a
CompletionList.

Signed-off-by: Remy Suen <remy.suen@gmail.com>

bundles/org.eclipse.orion.client.ui/web/orion/lsp/utils.js

@@ -241,7 +241,11 @@ define([
 		return editorContext.getFileMetadata().then(function(meta) {
 			return getEditorContextPosition(editorContext, args.selection.start).then(function(position) {
 				return provider.completion(meta.location, position).then(function(results) {
-						var items  = results.items;
+						// textDocument/completion requests may return a CompletionItem[] or a CompletionList
+						var items = results;
+						if (results.items) {
+							items = results.items;
+						}
 						if (Array.isArray(items) && items.length > 0) {
 							return Deferred.all(resolveCompletionItems(provider, editorContext, items)).then(function(proposals) {
 								return new Deferred().resolve(proposals);