Bug 525639 - Getting 403 instead of 404 when cloning a non-existing repo

eclipse · Oct 5, 2017 · e1f5c4a · e1f5c4a
1 parent 80a1d3e
commit e1f5c4a
Showing 1 changed file with 6 additions and 3 deletions.
diff --git a/modules/orionode/lib/git/clone.js b/modules/orionode/lib/git/clone.js
@@ -661,7 +661,7 @@ function handleRemoteError(task, err, cloneUrl) {
 	}
 	var u = url.parse(fullCloneUrl, true);
 	var code = err.code || 403;
-	var jsonData;
+	var jsonData, message = err.message;
 	if (err.message && ["credentials", "authentication", "401"].some(function(s) { return err.message.indexOf(s) !== -1; })) {
 		code = 401;
 		jsonData = {
@@ -672,13 +672,16 @@ function handleRemoteError(task, err, cloneUrl) {
 			"Url": cloneUrl,
 			"User": u.auth
 		};
+	} else if (err.message && ["404"].some(function(s) { return err.message.indexOf(s) !== -1; })) {
+		code = 404;
+		message = "Remote repository does not exist";
 	}
 	task.done({
 		HttpCode: code,
 		Code: 0,
 		JsonData: jsonData,
-		DetailedMessage: err.message,
-		Message: err.message,
+		DetailedMessage: message,
+		Message: message,
 		Severity: "Error"
 	});
 }