Workaround for https://bugs.eclipse.org/bugs/show_bug.cgi?id=520487 #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Boris Kuschel <kuschel@ca.ibm.com>
soulbeing
reviewed
Aug 3, 2017
| return fs.readFileSync(passwordFile,'utf8'); | ||
| var lines = fs.readFileSync(passwordFile,'utf8') | ||
| .split('\n').filter(Boolean); | ||
| return lines.length>0?lines[0]:null; |
There was a problem hiding this comment.
My comments are:
- Is it by convention only the first line of a passwordFile treated as the password? rather then the whole content(without carriage in between), so I don't know if this is the right way by design.
- Why filter(Boolean), I can't see what this code is doing. Array.filter expects a callback, but I don't know what a Boolean Constructor is doing here.
- Since I never used this feature before, and I don't know who is using it now, so basically if Silenio is fine with using only the first line, I'm totally OK with it as well.
There was a problem hiding this comment.
- Yes. There should only be one line. Problem is that there seems to be a bug in the readFileSync function that appends a carriage return. I think it's safe to ignore any garbage after a carriage return regardless
- filter Boolean takes garbage out of the array.
- I am using it in the orion build for kubernetes
soulbeing
approved these changes
Aug 3, 2017
soulbeing
pushed a commit
that referenced
this pull request
Aug 8, 2017
…134) Signed-off-by: Boris Kuschel <kuschel@ca.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Boris Kuschel kuschel@ca.ibm.com
@soulbeing could you review and merge this thx.