Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 520582 - Add check on calls to style provider API #135

Merged
merged 2 commits into from Aug 8, 2017

Conversation

caseyflynn-google
Copy link
Contributor

Verify that style providers have the method "getStyles" before attempting to
call it.

Signed-off-by: Casey Flynn caseyflynn@google.com

Verify that style providers have the method "getStyles" before attempting to
call it.

Signed-off-by: Casey Flynn <caseyflynn@google.com>
@eclipsewebmaster
Copy link

Issue tracker reference:
https://bugs.eclipse.org/bugs/show_bug.cgi?id=520582

Copy link
Contributor

@mrennie mrennie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't each typeof check the name of the function they are in? i.e. they all check getStyles, but shouldn't they check getThemeVersion, getDefaultTheme, etc?

Copy link
Contributor

@mrennie mrennie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now, thanks for the fast update!

@caseyflynn-google caseyflynn-google merged commit cd5f5ff into master Aug 8, 2017
@caseyflynn-google caseyflynn-google deleted the fixStyleProvider branch August 8, 2017 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants