Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 518659 - Remove usages of includes() in explorer-table #82

Merged
merged 2 commits into from Jun 22, 2017

Conversation

caseyflynn-google
Copy link
Contributor

Remove usages of ES6 includes.

Signed-off-by: Casey Flynn caseyflynn@google.com

Remove usages of ES6 includes.

Signed-off-by: Casey Flynn <caseyflynn@google.com>
@eclipsewebmaster
Copy link

Issue tracker reference:
https://bugs.eclipse.org/bugs/show_bug.cgi?id=518659

@snorthov
Copy link

Note that the Orion editor tooling flagged this as a problem. Too bad you were using another editor

Signed-off-by: Casey Flynn <caseyflynn@google.com>
Copy link
Contributor

@mrennie mrennie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@mrennie mrennie merged commit 51da0f7 into eclipse:master Jun 22, 2017
@caseyflynn-google caseyflynn-google deleted the Bug518659 branch June 22, 2017 20:13
carmacleod added a commit that referenced this pull request Jan 30, 2019
…ific enough when a screen reader lists them [62095] #82

- fixes item 2 part a by adding a label to the launch config "combo"
squarti pushed a commit that referenced this pull request Jan 30, 2019
…ific enough when a screen reader lists them [62095] #82 (#326)

- fixes item 2 part a by adding a label to the launch config "combo"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants