Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 518631 - [lsp] Orion does not consider TextDocumentSyncOptions from the server #87

Merged
merged 1 commit into from Jun 23, 2017

Conversation

rcjsuen
Copy link
Member

@rcjsuen rcjsuen commented Jun 23, 2017

Replace hardcoded values for TextDocumentSyncKind with constants.

…om the server

Replace hardcoded values for TextDocumentSyncKind with constants.

Signed-off-by: Remy Suen <remy.suen@gmail.com>
@rcjsuen rcjsuen requested a review from othomann June 23, 2017 13:39
@eclipsewebmaster
Copy link

Issue tracker reference:
https://bugs.eclipse.org/bugs/show_bug.cgi?id=518631

Copy link
Contributor

@othomann othomann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@othomann othomann merged commit 68c9917 into eclipse:java-lsp Jun 23, 2017
@rcjsuen rcjsuen deleted the constants branch June 23, 2017 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants