New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a modal "are you sure" dialog do the PGP managed key delete action #41

Closed
ctron opened this Issue Feb 24, 2016 · 3 comments

Comments

Projects
None yet
2 participants
@ctron
Contributor

ctron commented Feb 24, 2016

In the "PGP Signing" (managed version) view, there is a delete button which will delete the PGP key from the system. Each destructive operation should have a red action button and a modal dialog asking for confirmation.

The action does have a red trash button, but there is no modal dialog up until now. This has to be fixed.

@jeandersonbc

This comment has been minimized.

Show comment
Hide comment
@jeandersonbc

jeandersonbc Feb 24, 2016

Contributor

Agreed. Not to mention that the user is not aware about the consequences of a destructive action.
Could you assign this to me @ctron ?

Contributor

jeandersonbc commented Feb 24, 2016

Agreed. Not to mention that the user is not aware about the consequences of a destructive action.
Could you assign this to me @ctron ?

@ctron

This comment has been minimized.

Show comment
Hide comment
@ctron

ctron Feb 24, 2016

Contributor

Sadly no .. but this is just a limitation by GitHub. This works different with organization repositories.

So noted: you are working on it. And thanks for that! 👍

Contributor

ctron commented Feb 24, 2016

Sadly no .. but this is just a limitation by GitHub. This works different with organization repositories.

So noted: you are working on it. And thanks for that! 👍

jeandersonbc added a commit to jeandersonbc/packagedrone that referenced this issue Feb 25, 2016

Fixes #41 - Added Confirmation Dialog
Added modal reference for each delete row.

Signed-off-by: Jeanderson Candido <jeandersonbc@gmail.com>
@jeandersonbc

This comment has been minimized.

Show comment
Hide comment
@jeandersonbc

jeandersonbc Feb 25, 2016

Contributor

More details here #43 😄

Contributor

jeandersonbc commented Feb 25, 2016

More details here #43 😄

@ctron ctron closed this in 3572f61 Mar 2, 2016

ctron added a commit that referenced this issue Mar 2, 2016

Merge pull request #43 from jeandersonbc/issues/41
Fixes #41 - Added Confirmation Dialog

@ctron ctron added this to the v0.13.0.m2 milestone Mar 2, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment