Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

* [#247] Add optional flag to forcibly disconnect without sending… #246

Merged
merged 1 commit into from Sep 1, 2016

Conversation

mattrpav
Copy link
Contributor

@mattrpav mattrpav commented Aug 18, 2016

Please make sure that the following boxes are checked before submitting your Pull Request, thank you!

  • You have signed the Eclipse CLA
  • All of your commits have been signed-off with the correct email address (The same one that you used to sign the CLA)
  • If This PR fixes an issue, that you reference the issue below. OR if this is a new issue that you are fixing straight away that you add some Description about the bug and how this will fix it.
  • If this is new functionality, You have added the appropriate Unit tests.

… the disconnect packet to trigger LW message.

ref: #247
original bug ref: https://bugs.eclipse.org/bugs/show_bug.cgi?id=499935

Signed-off-by: Matt Pavlovich mattrpav@gmail.com

… the disconnect packet to trigger LW message.

 ref: https://bugs.eclipse.org/bugs/show_bug.cgi?id=499935

Signed-off-by: Matt Pavlovich <mattrpav@gmail.com>
@eclipsewebmaster
Copy link

Issue tracker reference:
https://bugs.eclipse.org/bugs/show_bug.cgi?id=4999935

@mattrpav
Copy link
Contributor Author

This feature closes a gap when compared to the FuseSource MQTT client where there is the ability to close a connection without sending the DISCONNECT packet. This allows for testing and simulating the triggering of the LastWill message using the Paho Java MQTT client.

@mattrpav mattrpav changed the title * [4999935] Add optional flag to forcibly disconnect without sending… * [#247] Add optional flag to forcibly disconnect without sending… Aug 19, 2016
@jpwsutton jpwsutton added this to the 1.3.0 milestone Aug 31, 2016
@jpwsutton jpwsutton self-assigned this Aug 31, 2016
@jpwsutton
Copy link
Member

@mattrpav Thanks for this PR, this seems like a good idea to me and would be quite handy with testing LastWill functionality.

In order for us to accept this PR, you will need to sign the Eclipse ECA, please see the FAQ here: https://www.eclipse.org/legal/ecafaq.php

@mattrpav
Copy link
Contributor Author

mattrpav commented Sep 1, 2016

@jpwsutton my Eclipse account is under 'mattrpav@gmail.com' and my preferences are showing me that the ECA confirmed. Let me know if I missed something.

Thanks,
Matt

@jpwsutton jpwsutton merged commit 7088ae9 into eclipse:develop Sep 1, 2016
@jpwsutton
Copy link
Member

Looks like the ECA check got caught looking at localhost for some reason, thanks for checking.

@mattrpav
Copy link
Contributor Author

mattrpav commented Sep 1, 2016

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants