Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SparqlProtocolSession uses this.getClass() as logger name #1970

Closed
aschwarte10 opened this issue Mar 5, 2020 · 0 comments
Closed

SparqlProtocolSession uses this.getClass() as logger name #1970

aschwarte10 opened this issue Mar 5, 2020 · 0 comments
Assignees
Labels
bug
Milestone

Comments

@aschwarte10
Copy link
Contributor

@aschwarte10 aschwarte10 commented Mar 5, 2020

The SparqlProtocolSession uses this.getClass() as a name for the logger.

In our application we have an extension of the class, which leads to misleading log output. Particularly the logging levels are also harder to control (w.r.t namespacing and packaging).

The general recommendation for logger names should be to use the class name, at least it should adhere to the rdf4j package structure.

@aschwarte10 aschwarte10 self-assigned this Mar 5, 2020
aschwarte10 added a commit to aschwarte10/rdf4j that referenced this issue Mar 5, 2020
The SparqlProtocolSession uses this.getClass() as a name for the logger.

When having an extension of the class, this leads to misleading log
output. Particularly the logging levels are also harder to control
(w.r.t namespacing and packaging).

The general recommendation for logger names should be to use the class
name, at least it should adhere to the rdf4j package structure.
@jeenbroekstra jeenbroekstra added the bug label Mar 6, 2020
@jeenbroekstra jeenbroekstra added this to the 3.1.2 milestone Mar 6, 2020
@jeenbroekstra jeenbroekstra added this to To do in Next releases via automation Mar 6, 2020
@jeenbroekstra jeenbroekstra moved this from To do to In progress in Next releases Mar 6, 2020
Next releases automation moved this from In progress to Done Mar 6, 2020
jeenbroekstra added a commit that referenced this issue Mar 6, 2020
The SparqlProtocolSession uses this.getClass() as a name for the logger.

When having an extension of the class, this leads to misleading log
output. Particularly the logging levels are also harder to control
(w.r.t namespacing and packaging).

The general recommendation for logger names should be to use the class
name, at least it should adhere to the rdf4j package structure.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Next releases
  
Done
Linked pull requests

Successfully merging a pull request may close this issue.

2 participants
You can’t perform that action at this time.