Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sort index entries to ensure Reproducible Build #5

Closed
wants to merge 1 commit into from

Conversation

@mcculls

This comment has been minimized.

Copy link
Contributor

mcculls commented Apr 9, 2019

Change looks good - previously the list followed the same order that the compiler processed the files, but I guess that could change depending on where the build ran (and whether it was an incremental build) so using alphabetical order is better.

PS. could you sign the ECA? https://www.eclipse.org/legal/ecafaq.php

@hboutemy

This comment has been minimized.

Copy link
Author

hboutemy commented Sep 22, 2019

@mcculls Hi Stuart, sorry I completely overlooked this ECA request...
done, with my personal email linked to the hboutemy GitHub account

asfgit pushed a commit to apache/maven that referenced this pull request Sep 22, 2019
asfgit pushed a commit to apache/maven that referenced this pull request Oct 20, 2019
asfgit pushed a commit to apache/maven that referenced this pull request Oct 20, 2019
asfgit pushed a commit to apache/maven that referenced this pull request Oct 20, 2019
asfgit pushed a commit to apache/maven that referenced this pull request Oct 20, 2019
asfgit pushed a commit to apache/maven that referenced this pull request Oct 23, 2019
asfgit pushed a commit to apache/maven that referenced this pull request Nov 3, 2019
@hboutemy

This comment has been minimized.

Copy link
Author

hboutemy commented Nov 6, 2019

@hboutemy hboutemy closed this Nov 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.