Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added sumSince (fixes #1843 replaces #376) #1854

Merged
merged 2 commits into from Jul 12, 2016

Conversation

Projects
None yet
3 participants
@watou
Copy link
Contributor

commented Jul 11, 2016

  • added sumSince (fixes #1843 replaces #376)
  • changed averageSince to use BigDecimal instead of double
  • changed evolutionRate to use BigDecimal instead of double
  • changed deltaSince to use BigDecimal instead of double
  • added check in evolutionRate method to avoid divide-by-zero error
  • updated all JavaDoc headers to reflect the odd variety of return values and their reasons, in hopes of spurring discussion as to whether and how to tighten and simplify the PersistenceExtensions.

Also-By: Jan N. Klug jan.n.klug@rub.de
Signed-off-by: John Cocula john@cocula.com

* changed averageSince to use BigDecimal instead of double
* added sumSince (fixes #1843 replaces #376)
* changed evolutionRate to use BigDecimal instead of double
* changed deltaSince to use BigDecimal instead of double
* added check in evolutionRate method to avoid divide-by-zero error
* updated all JavaDoc headers to reflect the odd variety of return values and their reasons, in hopes of spurring discussion as to whether and how to tighten and simplify the PersistenceExtensions.

Also-By: Jan N. Klug jan.n.klug@rub.de
Signed-off-by: John Cocula <john@cocula.com>
@maggu2810

This comment has been minimized.

Copy link
Contributor

commented Jul 12, 2016

Overall it looks good.
One remarks:
Can you change the modifiers to the common order (public static instead of static pulic).
The currently used order has not been changed or introduced by you, but as you already touched the function it is perhaps a good time to use a common one. WDYT?
I know there is no "wrong" but there is a suggestion for the order http://checkstyle.sourceforge.net/config_modifier.html

Changed modifier order to recommended order per @maggu2810
Signed-off-by: John Cocula <john@cocula.com>

@maggu2810 maggu2810 merged commit c362f8a into eclipse:master Jul 12, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
ip-validation
Details
@maggu2810

This comment has been minimized.

Copy link
Contributor

commented Jul 12, 2016

Thanks

@watou watou deleted the watou:add-sumSince branch Jul 12, 2016

@watou watou referenced this pull request Nov 3, 2016

Merged

Fix averageSince calculation #2405

@kaikreuzer kaikreuzer added this to the 0.9.0 milestone Nov 30, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.