Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LIFX Thing properties #3324

Merged
merged 1 commit into from May 5, 2017

Conversation

Projects
None yet
2 participants
@wborn
Copy link
Contributor

commented Apr 27, 2017

This PR adds adds the following Thing properties to LIFX lights:

  • hostVersion
  • macAddress
  • productId
  • productName
  • productVersion
  • vendorId
  • vendorName
  • wifiVersion
  • zones (only for lights that have MultiZone control, e.g. LIFX Z)

All properties (except for zones) are added during discovery. Apparently new property values from discovery results are not updated. E.g. when you would manually update the firmware via the LIFX app. Also these properties are not added to Things that already exist. I've submitted issue #3323 for this.

Furthermore I've removed the StateMeshFirmwareResponse GetMeshFirmwareRequest packets because these are remnants of the old LIFX protocol. StateMeshFirmwareResponse causes issues when response packets are received because it has the same packet type as StateHostFirmwareResponse.

LifxLightDiscovery will now also detect and skip lights that are not yet supported by the binding.

Add LIFX Thing properties
Signed-off-by: Wouter Born <eclipse@maindrain.net>
@kaikreuzer
Copy link
Member

left a comment

lgtm, thanks!

@kaikreuzer kaikreuzer merged commit f7155c4 into eclipse:master May 5, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
ip-validation
Details

@wborn wborn deleted the wborn:lifx-thing-properties branch May 9, 2017

@kaikreuzer kaikreuzer modified the milestone: 0.9.0 Jun 24, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.