Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Break circle dependency in GroupItem members #3795

Merged
merged 1 commit into from Jul 4, 2017

Conversation

Projects
None yet
3 participants
@triller-telekom
Copy link
Contributor

commented Jul 4, 2017

Fixes #3794

Signed-off-by: Stefan Triller stefan.triller@telekom.de

@@ -116,6 +116,9 @@ public GroupFunction getFunction() {

private void collectMembers(Set<Item> allMembers, Set<Item> members) {
for (Item member : members) {
if (allMembers.contains(member)) {
return;

This comment has been minimized.

Copy link
@sjka

sjka Jul 4, 2017

Contributor

how about continue instead of return? 😉

This comment has been minimized.

Copy link
@triller-telekom

triller-telekom Jul 4, 2017

Author Contributor

Just noticed that and changed the code but your continue is even better ;)

Well... that is only if I swap the allMembers.put and the recursive call too... So I think the if I have used now should be fine

@triller-telekom triller-telekom force-pushed the triller-telekom:groupItemCircleDependency branch from 6024db6 to c88d449 Jul 4, 2017

Break circle dependency in GroupItem members
Fixes #3794

Signed-off-by: Stefan Triller <stefan.triller@telekom.de>

@triller-telekom triller-telekom force-pushed the triller-telekom:groupItemCircleDependency branch from c88d449 to 9014da6 Jul 4, 2017

@sjka

sjka approved these changes Jul 4, 2017

Copy link
Contributor

left a comment

Much better, thanks!

@sjka sjka merged commit 1f6dd6d into eclipse:master Jul 4, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
ip-validation
Details

@triller-telekom triller-telekom deleted the triller-telekom:groupItemCircleDependency branch Jul 5, 2017

@kaikreuzer kaikreuzer added this to the 0.9.0 milestone Nov 30, 2017

@kaikreuzer kaikreuzer added the bug label Dec 15, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.