Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sonos binding: add state description on few channels #3800

Merged
merged 1 commit into from Jul 25, 2017

Conversation

Projects
None yet
3 participants
@lolodomo
Copy link
Contributor

commented Jul 4, 2017

Signed-off-by: Laurent Garnier lg.hc@free.fr

@lolodomo

This comment has been minimized.

Copy link
Contributor Author

commented Jul 5, 2017

Please wait for the end of discussion in the issue. Maybe this PR is not necessary if I provide a more general solution.

@sjka

This comment has been minimized.

Copy link
Contributor

commented Jul 6, 2017

just adding the "feedback" label to mark it as blocked

@lolodomo

This comment has been minimized.

Copy link
Contributor Author

commented Jul 6, 2017

I propose to merge it before the next release if no general fix is merged at this time.

@lolodomo

This comment has been minimized.

Copy link
Contributor Author

commented Jul 10, 2017

This PR may be closed and abandoned when #3822 is merged.

Sonos binding: add state description on few channels
Signed-off-by: Laurent Garnier <lg.hc@free.fr>

@lolodomo lolodomo force-pushed the lolodomo:sonos_pattern branch from 72d12a0 to a4b101c Jul 17, 2017

@lolodomo lolodomo changed the title Sonos binding: add a default pattern to string and number channels Sonos binding: add state description on few channels Jul 17, 2017

@lolodomo

This comment has been minimized.

Copy link
Contributor Author

commented Jul 17, 2017

@sjka : I changed the focus of this PR to simply add a state description on channels that require one (mainly for read-only channels) and reorder the channels in alphabetic order (few of them were previously added by me at the end of the file).

@kaikreuzer kaikreuzer removed the feedback label Jul 25, 2017

@kaikreuzer
Copy link
Member

left a comment

Lgtm, thanks!

@kaikreuzer kaikreuzer merged commit 2bc0584 into eclipse:master Jul 25, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
ip-validation
Details

@lolodomo lolodomo deleted the lolodomo:sonos_pattern branch Jul 25, 2017

@kaikreuzer kaikreuzer added this to the 0.9.0 milestone Nov 30, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.