Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sonos binding: handle Google Play Music radio #3940

Merged
merged 2 commits into from Aug 9, 2017

Conversation

Projects
None yet
3 participants
@lolodomo
Copy link
Contributor

commented Aug 3, 2017

Fix #3937

Signed-off-by: Laurent Garnier lg.hc@free.fr

@lolodomo

This comment has been minimized.

Copy link
Contributor Author

commented Aug 3, 2017

Please wait, I think I made an unnecessary (wrong) distinction between tunein radio and GPM radio when handling sound notification s.

Sonos binding: handle Google Play Music radio
Fix #3937

Signed-off-by: Laurent Garnier <lg.hc@free.fr>

@lolodomo lolodomo force-pushed the lolodomo:sonos_gpm branch from 120bcf7 to e868639 Aug 3, 2017

@lolodomo

This comment has been minimized.

Copy link
Contributor Author

commented Aug 3, 2017

Change done; ready for review and merge.

@lolodomo

This comment has been minimized.

Copy link
Contributor Author

commented Aug 3, 2017

Travis is failing in Eclipse SmartHome Core Binding XML Tests on something that cannot have a link with my current change.

In my local environment, the Maven build is failing earlier in Eclipse SmartHome Core Tests with something else without any link with my change? I will open an issue for that.

@lolodomo

This comment has been minimized.

Copy link
Contributor Author

commented Aug 4, 2017

@kgoderis : any chance that you review this little change ?

Sonos binding: define unit for configuration settings
Signed-off-by: Laurent Garnier <lg.hc@free.fr>
@maggu2810

This comment has been minimized.

Copy link
Contributor

commented Aug 9, 2017

@kgoderis : any chance that you review this little change ?

I don't think so. See here: #3912 (comment)

@maggu2810 maggu2810 merged commit fa773e8 into eclipse:master Aug 9, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@lolodomo lolodomo deleted the lolodomo:sonos_gpm branch Aug 9, 2017

@lolodomo

This comment has been minimized.

Copy link
Contributor Author

commented Aug 9, 2017

Thank you

@kaikreuzer kaikreuzer added this to the 0.9.0 milestone Nov 30, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.