Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Astro: Fix applying earliest and latest config on channel #4061
The problem is that applying the config to every single event is too late because then you cannot compare the times of 2 events afterwards. And in order to not apply the config twice I introduced the variable.
Aug 16, 2017
referenced this pull request
Aug 18, 2017
I'm not into release management and github... so excuse me for asking: This should be in the stable release at the latest of 2.2?
in short: defining earliest AND latest in one config results in events firing regardless the configuration times.
see forum entry, but basically this is my thing-configuration:
so I would expect the Events to start and end accordingly in at least v2.2 stable.
just yesterday evening I switched the earliest and latest lines in the Thing. Same Outcome:
but, I find this one interesting (at 00:30 at night?):
Alright, I found the bug in your configuration:
You are configuring
If you would have added the thing via paperUI so you could have also configured it via paperUI you would have seen that it works, because there the name is correct :)
oh - I'm afraid that's not the solution yet! ;)
but still, from the log the last 24h:
(no night#event END as of now yet?)
please tell me, I didn't catch it, because it's still not working...
strangely enough, still no astro:sun:home:night#event triggered END ?
if it helps:
I am sorry, but I cannot reproduce this issue here. If you still think that is is not working, please minify your setup, i.e. only keep the 2 night channels, see if the problem persists and if it does, post a new issue with it.
This is a closed PR and thus you should continue this in a new issue if it still persists with a minimal example. You can link the discussion from here in the new issue.