Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sonos: play TuneIn by a station id #4229

Merged
merged 1 commit into from Sep 16, 2017

Conversation

Projects
None yet
5 participants
@lolodomo
Copy link
Contributor

commented Sep 9, 2017

Channel table fully updated in the documentation with the access mode added for each channel

Signed-off-by: Laurent Garnier lg.hc@free.fr

@lolodomo lolodomo force-pushed the lolodomo:sonos_tunein branch 2 times, most recently from 8bc929b to 9db19e7 Sep 9, 2017

@lolodomo

This comment has been minimized.

Copy link
Contributor Author

commented Sep 11, 2017

@kgoderis : could you please review this change ?

@kaikreuzer
Copy link
Member

left a comment

Code lgtm, would be nice to have some feedback from @kgoderis or @wborn if it also works as expected, before we merge it.

@sjka

This comment has been minimized.

Copy link
Contributor

commented Sep 15, 2017

Just tried it out - works like a charm for me 👍

@sjka

sjka approved these changes Sep 15, 2017

@@ -132,6 +134,8 @@

private Map<String, String> stateMap = Collections.synchronizedMap(new HashMap<String, String>());

private List<SonosMusicService> msuicServices;

This comment has been minimized.

Copy link
@wborn

wborn Sep 15, 2017

Contributor

I don't own or use any Sonos devices. But "msuicServices" looks like a typo. :-)

This comment has been minimized.

Copy link
@kaikreuzer

kaikreuzer Sep 15, 2017

Member

Good catch :-)
Ah, sorry, don't know where my head is these days... I somehow mixed up Sonos with LIFX... So forget about my testing request unless you can make your bulbs play some music 🤣

This comment has been minimized.

Copy link
@lolodomo

lolodomo Sep 15, 2017

Author Contributor

lol

Sonos: play TuneIn by a station id
Channel table fully updated in the documentation with the access mode added for each channel

Signed-off-by: Laurent Garnier <lg.hc@free.fr>

@lolodomo lolodomo force-pushed the lolodomo:sonos_tunein branch from 474f882 to 6a9305c Sep 15, 2017

@lolodomo

This comment has been minimized.

Copy link
Contributor Author

commented Sep 15, 2017

Typo fixed + everything squashed.

@maggu2810 maggu2810 merged commit 47de57e into eclipse:master Sep 16, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
ip-validation
Details

@lolodomo lolodomo deleted the lolodomo:sonos_tunein branch Sep 16, 2017

@kaikreuzer kaikreuzer added this to the 0.9.0 milestone Nov 30, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.