Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI] Charts Enhancements: Themes, DPI, legend hiding #4291

Merged
merged 1 commit into from Sep 25, 2017

Conversation

Projects
None yet
3 participants
@hreichert
Copy link
Contributor

commented Sep 17, 2017

Add some enhancements to the ChartServlet, DefaultChartProvider, REST API, BasicUI/ClassicUI to support the following things:

  • Chart themes for different looks
  • dpi parameter for dynamic sizes based on DPI
  • Automatic showing/hiding of the legend based on number of chart series
  • legend parameter to hide/show the chart legend

Please see issue #4288 for all details.
The first comment has a up2date description.

❗️ This breaks the OH1 compatibility layer: org.openhab.ui.chart.internal.ChartProviderDelegate
If this gets merged, I create a PR in openhab/openhab-core


Renderings
Default theme "bright", default settings:
chart_1
Theme "dark", default settings:
chart_2
Theme "black", default settings:
chart_3

@hreichert hreichert force-pushed the hreichert:4288-charts-enhancements branch 3 times, most recently from 575dddc to e14c21f Sep 19, 2017

[UI] Charts Enhancements: Themes, DPI, legend hiding #4288
Signed-off-by: Holger Reichert <mail@h0lger.de>

@hreichert hreichert changed the title [WIP] [Charts] Enhancements to Charts: Themes, FontScale, HideLegend (#4288) [UI] Charts Enhancements: Themes, DPI, legend hiding Sep 21, 2017

@hreichert hreichert force-pushed the hreichert:4288-charts-enhancements branch from e14c21f to 0d743a2 Sep 21, 2017

@kaikreuzer kaikreuzer added the UI label Sep 22, 2017

@kaikreuzer
Copy link
Member

left a comment

Many thanks, looks all perfect!

@kaikreuzer kaikreuzer merged commit 4dd53d9 into eclipse:master Sep 25, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
ip-validation
Details

@hreichert hreichert deleted the hreichert:4288-charts-enhancements branch Sep 25, 2017

@hreichert

This comment has been minimized.

Copy link
Contributor Author

commented Sep 25, 2017

Thank you @kaikreuzer

@kaikreuzer

This comment has been minimized.

Copy link
Member

commented Sep 25, 2017

Time to prepare the PR for openhab-core now :-)

@hreichert

This comment has been minimized.

Copy link
Contributor Author

commented Sep 25, 2017

Sure, here you go: openhab/openhab-core#215
But the travis build for this commit will not succeed now...

@mueller-ma mueller-ma referenced this pull request Sep 27, 2017

Closed

Charts are not themed #383

mueller-ma added a commit to mueller-ma/openhab.android that referenced this pull request Sep 29, 2017

Make use of eclipse/smarthome#4291
This commit enhances charts to support themes, scale legend according to
dpi and create option to hide legend

Signed-off-by: mueller-ma <mueller-ma@users.noreply.github.com>

mueller-ma added a commit to mueller-ma/openhab.android that referenced this pull request Sep 30, 2017

Make use of eclipse/smarthome#4291
This commit enhances charts to support themes, scale legend according to
dpi and create option to hide legend

Signed-off-by: mueller-ma <mueller-ma@users.noreply.github.com>

digitaldan added a commit to openhab/openhab-android that referenced this pull request Oct 8, 2017

Make use of eclipse/smarthome#4291 (#386)
* Make use of eclipse/smarthome#4291

This commit enhances charts to support themes, scale legend according to
dpi and create option to hide legend

Signed-off-by: mueller-ma <mueller-ma@users.noreply.github.com>

* Read legend setting from oh server

Signed-off-by: mueller-ma <mueller-ma@users.noreply.github.com>

* Use Boolean

Signed-off-by: mueller-ma <mueller-ma@users.noreply.github.com>

@kaikreuzer kaikreuzer added this to the 0.9.0 milestone Nov 30, 2017

@openhab-bot

This comment has been minimized.

Copy link
Contributor

commented May 21, 2018

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/charts-are-not-working-as-before-anymore-broken/41208/41

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.