Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BasicUI] Integrate ChartThemes in BasicUI themes #4336

Merged

Conversation

Projects
None yet
2 participants
@hreichert
Copy link
Contributor

commented Sep 25, 2017

This PR integrates chart themes to the BasicUI.

  • #4137 introduced BasicUI themes
  • #4291 introduced chart themes

Take a matching ChartTheme for the current BasicUI theme:

  • If the dark theme is choosen in BasicUI, render a dark chart.
  • If the default theme is choosen in BasicUI, render a bright chart.

As the bright chart theme has the same colors as the previous/current chart, there is no change if someone uses the default BasicUI theme.

BasicUI default:
basicui_chart_default

BasicUI dark:
basicui_chart_dark

[BasicUI] Integrate ChartThemes in BasicUI themes
Take a matching ChartTheme for the current BasicUI theme.

Signed-off-by: Holger Reichert <mail@h0lger.de>
@kaikreuzer
Copy link
Member

left a comment

Excellent, thanks!

@kaikreuzer kaikreuzer merged commit e135552 into eclipse:master Sep 26, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
ip-validation
Details

@hreichert hreichert deleted the hreichert:basicui-chart-theme-integration branch Sep 26, 2017

@kaikreuzer kaikreuzer added this to the 0.9.0 milestone Nov 30, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.