Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic/Classic UI: support for HTTP Live Stream #4386

Merged
merged 1 commit into from Oct 10, 2017

Conversation

Projects
None yet
3 participants
@lolodomo
Copy link
Contributor

commented Oct 8, 2017

Add support for HLS in compatible WEB browsers
Use encoding="HLS" in the video sitemap element.

Signed-off-by: Laurent Garnier lg.hc@free.fr

@lolodomo

This comment has been minimized.

Copy link
Contributor Author

commented Oct 8, 2017

I tested it with Chrome on Android.
I can't test with Apple devices but it should work in Safari (Mac or iOs).

Basic/Classic UI: support for HTTP Live Stream
Add support for HLS in compatible WEB browsers
Use encoding="HLS" in the video sitemap element.

Signed-off-by: Laurent Garnier <lg.hc@free.fr>

@lolodomo lolodomo force-pushed the lolodomo:hls branch from 5c542f7 to 2daffc2 Oct 8, 2017

@lolodomo

This comment has been minimized.

Copy link
Contributor Author

commented Oct 8, 2017

As an example, this change allows the rendering of video from the Netatmo Welcome camera.

You can find compatible browsers with HLS in wikipedia: https://en.wikipedia.org/wiki/HTTP_Live_Streaming

@lolodomo

This comment has been minimized.

Copy link
Contributor Author

commented Oct 8, 2017

I tested with the 5 m3u8 links proposed on this page: https://bitmovin.com/mpeg-dash-hls-examples-sample-streams/

                Video url="https://bitdash-a.akamaihd.net/content/MI201109210084_1/m3u8s/f08e80da-bf1d-4e3d-8899-f0f6155f6efa.m3u8" encoding="HLS"
                Video url="https://bitdash-a.akamaihd.net/content/sintel/hls/playlist.m3u8" encoding="HLS"
                Video url="https://mnmedias.api.telequebec.tv/m3u8/29880.m3u8" encoding="HLS"
                Video url="http://184.72.239.149/vod/smil:BigBuckBunny.smil/playlist.m3u8" encoding="HLS"
                Video url="http://www.streambox.fr/playlists/test_001/stream.m3u8" encoding="HLS"

It is working well in Chrome (Android) and in Microsoft Edge (Windows 10).

Unfortunately Netatmo welcome links are not working in Microsoft Edge.

@lolodomo

This comment has been minimized.

Copy link
Contributor Author

commented Oct 8, 2017

Even if I am very confident, it would be cool if someone can test with Safari browser on iOS and Mac.

@sjka

This comment has been minimized.

Copy link
Contributor

commented Oct 9, 2017

At lest the middle one works on Safari @ macOS and Safaris @ iOS. I'm not sure whether it's just that the others are simply not available/overloaded right now or it that points to some other issues.

None of them works in Chrome @ macOS/Windows 10, which is expected though if I read this Wikipedia page correctly.

This is according to your expectations, right?

@lolodomo

This comment has been minimized.

Copy link
Contributor Author

commented Oct 9, 2017

Are your tests really done with the updated UIs from this PR ?
The 5 links were available yesterday and I am expecting that they all works in Safari with my changes.
As a reminder, they all work in Chrome/Android and Edge/Windows 10 with this PR.

@sjka

This comment has been minimized.

Copy link
Contributor

commented Oct 9, 2017

Ouch, my bad - got the IPs mixed up, sorry.
They are indeed all good on Safari on both OSes!

@sjka

This comment has been minimized.

Copy link
Contributor

commented Oct 9, 2017

Just one question regarding the encoding configuration - unfortunately we have no documentation about sitemaps here, so the best I could find was the one from openHAB. There it says that the encoding attribute "can stay left empty for auto selection" [sic]. This does not hold true anymore, right? Is it somehow possible to auto-detect HLS streams?

@lolodomo

This comment has been minimized.

Copy link
Contributor Author

commented Oct 9, 2017

I will update this documentation once this PR is merged to explain that "hls" has to be set for m3u8 files (HLS).

@lolodomo

This comment has been minimized.

Copy link
Contributor Author

commented Oct 9, 2017

Thank you for your additional tests @sjka . I think we have tested with success in all compatible WEB browsers. Note that it should work in Chrome/iOS too.

@kaikreuzer
Copy link
Member

left a comment

lgtm, thanks!

@kaikreuzer kaikreuzer merged commit 2e6af75 into eclipse:master Oct 10, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
ip-validation
Details

@lolodomo lolodomo deleted the lolodomo:hls branch Oct 10, 2017

@kaikreuzer kaikreuzer added this to the 0.9.0 milestone Nov 30, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.