Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesign volume icon. #4414

Merged
merged 3 commits into from Oct 13, 2017

Conversation

Projects
None yet
2 participants
@reitermarkus
Copy link
Contributor

commented Oct 12, 2017

Closes #3354.

@reitermarkus reitermarkus force-pushed the reitermarkus:volume-icon branch from bcdebc6 to 8b59935 Oct 12, 2017

reitermarkus added some commits Oct 12, 2017

Redesign volume icon.
Signed-off-by: Markus Reiter <me@reitermark.us>
Update `_iconconvert` script.
Signed-off-by: Markus Reiter <me@reitermark.us>
Update `_iconcopy` script.
Signed-off-by: Markus Reiter <me@reitermark.us>

@reitermarkus reitermarkus force-pushed the reitermarkus:volume-icon branch from 8b59935 to 6e946f7 Oct 12, 2017

@kaikreuzer
Copy link
Member

left a comment

Thanks, I like the new version much better, it nicely fits into the overall iconset design!

@kaikreuzer kaikreuzer merged commit 9ffe382 into eclipse:master Oct 13, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
ip-validation
Details
@kaikreuzer

This comment has been minimized.

Copy link
Member

commented Oct 13, 2017

Btw, did you see the updates in the icon category restructuring?
If you'd find the time and have good ideas for missing icons (where there is currently a question mark), it would be awesome: https://www.eclipse.org/smarthome/documentation/features/ui/iconset/classic/readme.html

@reitermarkus reitermarkus deleted the reitermarkus:volume-icon branch Oct 13, 2017

@reitermarkus

This comment has been minimized.

Copy link
Contributor Author

commented Oct 13, 2017

Btw, did you see the updates in the icon category restructuring?

No I haven't, but I'll try to keep it in mind if I find the time. 😉

@kaikreuzer kaikreuzer added this to the 0.9.0 milestone Nov 30, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.