Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

introduced config option provider for serial ports #4568

Merged
merged 2 commits into from Nov 16, 2017

Conversation

Projects
None yet
3 participants
@kaikreuzer
Copy link
Member

commented Nov 16, 2017

This PR adds an optional bundle, which can provide a list of available serial ports as configuration parameter options.

FTR, I am aware that #4465 has not been decided yet, but I think this feature is pretty useful and the implementation so small that it can be easily adapted once we reach a consensus on #4465.

Signed-off-by: Kai Kreuzer kai@openhab.org

introduced config option provider for serial ports
Signed-off-by: Kai Kreuzer <kai@openhab.org>
@htreu

htreu approved these changes Nov 16, 2017

@htreu

This comment has been minimized.

Copy link
Contributor

commented Nov 16, 2017

@kaikreuzer please update the documentation at docs/documentation/development/bindings/xml-reference.md and append the new context.

@htreu

This comment has been minimized.

Copy link
Contributor

commented Nov 16, 2017

And karaf feature validation is not happy.

@kaikreuzer

This comment has been minimized.

Copy link
Member Author

commented Nov 16, 2017

please update the documentation at docs/documentation/development/bindings/xml-reference.md

You mean this is not good enough?

added esh-tp-serial to esh-tp
Signed-off-by: Kai Kreuzer <kai@openhab.org>

@sjka sjka merged commit 1b003c6 into eclipse:master Nov 16, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
ip-validation
Details

@kaikreuzer kaikreuzer deleted the kaikreuzer:serialconfig branch Nov 16, 2017

@kaikreuzer kaikreuzer added this to the 0.9.0 milestone Nov 30, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.